Allow cleaning up of networks stuck in Implementing state

[Pearl1594]

Description

This PR fixes: #12249
This PR allows cleanup of Networks that have been stuck in Implementing state for more than the job.expire.minutes setting and has no async jobs associated.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

1. Created a network
2. Created a VM in that network and cleaned up the VM
3. Set network (manually in DB) to Implementing state
4. Observe logs (temporarily placed one of the trace logs in the code as debug)

...
Found 1 networks in Implementing state, checking for orphaned networks
2026-01-12 16:43:58,432 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] (AsyncJobMgr-Heartbeat-1:[ctx-abe618b0]) (logid:5ee73b3f) Network 204 in Implementing state is only 9 minutes old (threshold: 10 minutes), skipping cleanup
..
 Found 1 networks in Implementing state, checking for orphaned networks
2026-01-12 16:44:08,434 WARN  [o.a.c.f.j.i.AsyncJobManagerImpl] (AsyncJobMgr-Heartbeat-1:[ctx-5012868f]) (logid:8c11718f) Found orphaned network 204 in Implementing state without async job. Network created: 2026-01-12T16:34:05.000+0000, age: 10 minutes, expiration threshold: 10 minutes. Transitioning to Shutdown state.

...
<img width="1621" height="147" alt="image" src="https://github.com/user-attachments/assets/8aadf16e-c022-4502-b88f-7c090a18e5f3" />

Moves network to Shutdown state and from there the networks can be deleted.

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

❌ Patch coverage is 0% with 57 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.65%. Comparing base (4348386) to head (d6fe913).
⚠️ Report is 99 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...stack/framework/jobs/impl/AsyncJobManagerImpl.java	0.00%	57 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20   #12409      +/-   ##
============================================
+ Coverage     16.21%   16.65%   +0.43%     
- Complexity    13353    14136     +783     
============================================
  Files          5657     5660       +3     
  Lines        498647   520073   +21426     
  Branches      60533    69103    +8570     
============================================
+ Hits          80863    86603    +5740     
- Misses       408771   424021   +15250     
- Partials       9013     9449     +436     

Flag	Coverage Δ
uitests	5.00% <ø> (+0.99%)	⬆️
unittests	17.47% <0.00%> (+0.40%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[DaanHoogland]

one nitpit, I would disect cleanupOrphanedNetworks() further as well.

[DaanHoogland]

there is a try catch as highest level inside cleanupOrphanedNetworks(), is this one needed?

[Pearl1594]

Just following how the other cases are handled. Also, we will be able to know which operation really failed in this block

[DaanHoogland]

ok, then we should factor this one out in a new method I think.

[Pearl1594]

@blueorangutan package

[blueorangutan]

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16600

[nvazquez]

@blueorangutan test

[blueorangutan]

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-15335)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 51086 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12409-t15335-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[sudo87]

clgtm

[sonarqubecloud]

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud