Fix template details deletion while updating template from UI

[sureshanaparti]

Description

This PR fixes the template details deletion while updating template from UI.

Fixes #12456

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Updated rootdiskcontoller for the template (having some existing details) from UI.

How did you try to break this feature and the system with this change?

[sureshanaparti]

@blueorangutan ui

[blueorangutan]

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.26%. Comparing base (25eacaa) to head (5be56c8).
⚠️ Report is 4 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...che/cloudstack/api/BaseUpdateTemplateOrIsoCmd.java	0.00%	2 Missing ⚠️
.../java/com/cloud/storage/dao/VMTemplateDaoImpl.java	0.00%	2 Missing ⚠️
...n/java/com/cloud/template/TemplateManagerImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20   #12559      +/-   ##
============================================
- Coverage     16.26%   16.26%   -0.01%     
  Complexity    13428    13428              
============================================
  Files          5660     5660              
  Lines        499914   499959      +45     
  Branches      60696    60707      +11     
============================================
+ Hits          81318    81324       +6     
- Misses       409523   409561      +38     
- Partials       9073     9074       +1     

Flag	Coverage Δ
uitests	4.16% <ø> (-0.01%)	⬇️
unittests	17.11% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/12559 (QA-JID-866)

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16655

[DaanHoogland]

clgtm

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-15350)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 51329 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12559-t15350-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[kiranchavala]

@sureshanaparti As discussed the issue still exists, tested with the pr packages

[sureshanaparti]

@blueorangutan ui

[blueorangutan]

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/12559 (QA-JID-868)

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16678

[kiranchavala]

@sureshanaparti

The ui works fine, facing with the manual executing of the API call

(localcloud) 🐱 > list templates id=21ebaea2-d7c3-4471-ace3-396d5cb5d57e  filter=details, templatefilter=all
{
  "count": 1,
  "template": [
    {
      "details": {
        "rootDiskController": "osdefault"
      }
    }
  ]
}
(localcloud) 🐱 > update template id=21ebaea2-d7c3-4471-ace3-396d5cb5d57e details[0].UEFI=secure filter=details
{
  "template": {
    "details": {
      "UEFI": "SECURE"
    }
  }
}
(localcloud) 🐱 > list templates id=21ebaea2-d7c3-4471-ace3-396d5cb5d57e  filter=details, templatefilter=all
{
  "count": 1,
  "template": [
    {
      "details": {
        "UEFI": "SECURE"
      }
    }
  ]
}

[kiranchavala]

LGTM

From the ui , the fix is working

Screen.Recording.2026-02-03.at.1.38.07.PM.mov

For the API part , if you want to add a single detail to a resource please use the

https://cloudstack.apache.org/api/apidocs-4.22/apis/addResourceDetail.html
https://cloudstack.apache.org/api/apidocs-4.22/apis/listResourceDetails.html

(localcloud) 🐱 > add resourcedetail resourceid=21ebaea2-d7c3-4471-ace3-396d5cb5d57e resourcetype=template details[0].key=UEFI details[0].value=secure
{
  "success": true
}
(localcloud) 🐱 > list resourcedetails resourcetype=template resourceid=21ebaea2-d7c3-4471-ace3-396d5cb5d57e
{
  "count": 2,
  "resourcedetail": [
    {
      "fordisplay": true,
      "key": "rootDiskController",
      "resourceid": "21ebaea2-d7c3-4471-ace3-396d5cb5d57e",
      "resourcetype": "Template",
      "value": "scsi"
    },
    {
      "fordisplay": true,
      "key": "UEFI",
      "resourceid": "21ebaea2-d7c3-4471-ace3-396d5cb5d57e",
      "resourcetype": "Template",
      "value": "secure"
    }
  ]
}