Skip to content

Fix issue with multiple KVM Host entries in host table#12589

Open
nvazquez wants to merge 1 commit intoapache:4.20from
shapeblue:420-fix-multiple-kvm-host-entries
Open

Fix issue with multiple KVM Host entries in host table#12589
nvazquez wants to merge 1 commit intoapache:4.20from
shapeblue:420-fix-multiple-kvm-host-entries

Conversation

@nvazquez
Copy link
Contributor

@nvazquez nvazquez commented Feb 5, 2026

Description

This PR addresses an issue in which multiple KVM host entries are created on the host table during release when the agent on the host has "old" GUID format (with and without resource), having multiple entries for the same KVM host. This PR addresses the issue by reusing existing records matching the GIUD (or GIUD prefix)

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

❌ Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.26%. Comparing base (9ae696d) to head (83f239d).

Files with missing lines Patch % Lines
...n/java/com/cloud/resource/ResourceManagerImpl.java 0.00% 20 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.20   #12589      +/-   ##
============================================
- Coverage     16.26%   16.26%   -0.01%     
- Complexity    13428    13429       +1     
============================================
  Files          5660     5660              
  Lines        499963   499980      +17     
  Branches      60708    60709       +1     
============================================
+ Hits          81330    81331       +1     
- Misses       409559   409576      +17     
+ Partials       9074     9073       -1     
Flag Coverage Δ
uitests 4.16% <ø> (ø)
unittests 17.12% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nvazquez
Copy link
Contributor Author

nvazquez commented Feb 5, 2026

@blueorangutan package

@nvazquez nvazquez added this to the 4.20.3 milestone Feb 5, 2026
@blueorangutan
Copy link

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16702

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants