UI: Show applied search filters by vishesh92 · Pull Request #9520 · apache/cloudstack

vishesh92 · 2024-08-13T09:38:32Z

Description

This PR adds the feature to show applied search filters in the UI.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

vishesh92 · 2024-08-13T09:38:53Z

@blueorangutan ui

blueorangutan · 2024-08-13T09:40:04Z

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

codecov · 2024-08-13T09:49:38Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.26%. Comparing base (35e6d7c) to head (7425811).
⚠️ Report is 11 commits behind head on 4.20.

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20    #9520      +/-   ##
============================================
- Coverage     16.26%   16.26%   -0.01%     
  Complexity    13418    13418              
============================================
  Files          5658     5660       +2     
  Lines        499494   499863     +369     
  Branches      60625    60690      +65     
============================================
+ Hits          81232    81284      +52     
- Misses       409214   409509     +295     
- Partials       9048     9070      +22

Flag	Coverage Δ
uitests	`4.15% <ø> (+0.12%)`	⬆️
unittests	`17.11% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2024-08-13T09:58:02Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9520 (QA-JID-419)

vishesh92 · 2024-08-13T12:10:43Z

@blueorangutan ui

blueorangutan · 2024-08-13T12:12:04Z

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2024-08-13T12:29:36Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9520 (QA-JID-420)

vishesh92 · 2024-08-16T07:50:08Z

@blueorangutan ui

blueorangutan · 2024-08-16T07:51:05Z

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2024-08-16T08:07:53Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9520 (QA-JID-421)

ui/src/components/view/SearchFilter.vue

sureshanaparti · 2024-08-16T08:46:38Z

Search message not in sync with filters =>

UUIDs loaded instead of name for Zone, Group in filter view (on close & re-open) - Check if selected names can be populated as before =>

uuid-loaded-on-filter-view-zone-and-group

vishesh92 · 2024-08-27T09:32:00Z

@blueorangutan ui

blueorangutan · 2024-08-27T09:33:04Z

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2024-08-27T09:49:51Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9520 (QA-JID-434)

DaanHoogland

clgtm tested in qa

vishesh92 · 2026-01-28T13:19:40Z

@blueorangutan ui

blueorangutan · 2026-01-28T13:20:04Z

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2026-01-28T13:38:05Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9520 (QA-JID-857)

borisstoyanov · 2026-01-28T13:47:00Z

LGTM

DaanHoogland · 2026-01-28T13:49:24Z

@vishesh92 , can you look at the ui build (test) issues?

Copilot

Pull request overview

Adds UI support to display currently applied search filters (from route query params) as removable “chips” beneath the search bar.

Changes:

Render a new SearchFilter row in AutogenView when enabled by config.
Introduce SearchFilter.vue to format query params into human-readable tags and allow removing them.
Add a showSearchFilters flag to ui/public/config.json.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 10 comments.

File	Description
ui/src/views/AutogenView.vue	Adds a conditional row to show applied search filters and handles removing them by updating route query params.
ui/src/components/view/SearchFilter.vue	New component that renders filter tags, resolves display labels/values (including via API calls), and emits removals.
ui/public/config.json	Adds a config flag to toggle the feature.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ui/src/components/view/SearchFilter.vue

ui/src/views/AutogenView.vue

vishesh92 · 2026-01-29T09:59:54Z

@blueorangutan ui

blueorangutan · 2026-01-29T10:01:04Z

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2026-01-29T10:19:14Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9520 (QA-JID-860)

sureshanaparti · 2026-01-29T12:23:40Z

@blueorangutan ui

blueorangutan · 2026-01-29T12:25:04Z

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2026-01-29T12:43:56Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9520 (QA-JID-861)

DaanHoogland · 2026-01-29T14:17:02Z

verified in qa

boring-cyborg bot added the component:UI label Aug 13, 2024

vishesh92 force-pushed the ui-show-search-filters branch 2 times, most recently from 47e4a82 to 00985d0 Compare August 13, 2024 12:10

vishesh92 force-pushed the ui-show-search-filters branch from 00985d0 to 21ca320 Compare August 16, 2024 07:49

sureshanaparti reviewed Aug 16, 2024

View reviewed changes

ui/src/components/view/SearchFilter.vue Show resolved Hide resolved

vishesh92 force-pushed the ui-show-search-filters branch from 267d78b to 1655b61 Compare August 16, 2024 10:23

vishesh92 force-pushed the ui-show-search-filters branch 3 times, most recently from a2a3260 to b0ea771 Compare August 27, 2024 08:42

apache deleted a comment from blueorangutan Aug 27, 2024

apache deleted a comment from blueorangutan Aug 28, 2024

DaanHoogland approved these changes Aug 28, 2024

View reviewed changes

vishesh92 force-pushed the ui-show-search-filters branch 2 times, most recently from 533ab77 to 6b51f58 Compare January 28, 2026 13:17

UI: Show applied search filters

07bd2de

vishesh92 force-pushed the ui-show-search-filters branch from 6b51f58 to 07bd2de Compare January 28, 2026 13:19

DaanHoogland modified the milestones: 4.22.1, 4.20.3 Jan 28, 2026

DaanHoogland removed this from Apache CloudStack 4.22.1 Jan 28, 2026

borisstoyanov approved these changes Jan 28, 2026

View reviewed changes

borisstoyanov marked this pull request as ready for review January 28, 2026 13:47

Copilot AI review requested due to automatic review settings January 28, 2026 13:47

Copilot started reviewing on behalf of borisstoyanov January 28, 2026 13:48 View session

Copilot AI reviewed Jan 28, 2026

View reviewed changes

Address comments

8c634cd

fix failing ui test

7425811

sureshanaparti self-assigned this Jan 29, 2026

DaanHoogland merged commit 0e94f7d into apache:4.20 Jan 29, 2026
26 checks passed

vishesh92 mentioned this pull request Jan 30, 2026

Update search filter size dynamically #12552

Merged

14 tasks

DaanHoogland deleted the ui-show-search-filters branch January 30, 2026 07:32

Conversation

vishesh92 commented Aug 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

vishesh92 commented Aug 13, 2024

Uh oh!

blueorangutan commented Aug 13, 2024

Uh oh!

codecov bot commented Aug 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Aug 13, 2024

Uh oh!

vishesh92 commented Aug 13, 2024

Uh oh!

blueorangutan commented Aug 13, 2024

Uh oh!

blueorangutan commented Aug 13, 2024

Uh oh!

vishesh92 commented Aug 16, 2024

Uh oh!

blueorangutan commented Aug 16, 2024

Uh oh!

blueorangutan commented Aug 16, 2024

Uh oh!

Uh oh!

sureshanaparti commented Aug 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vishesh92 commented Aug 27, 2024

Uh oh!

blueorangutan commented Aug 27, 2024

Uh oh!

blueorangutan commented Aug 27, 2024

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

vishesh92 commented Jan 28, 2026

Uh oh!

blueorangutan commented Jan 28, 2026

Uh oh!

blueorangutan commented Jan 28, 2026

Uh oh!

borisstoyanov commented Jan 28, 2026

Uh oh!

DaanHoogland commented Jan 28, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vishesh92 commented Jan 29, 2026

Uh oh!

blueorangutan commented Jan 29, 2026

Uh oh!

blueorangutan commented Jan 29, 2026

Uh oh!

sureshanaparti commented Jan 29, 2026

Uh oh!

blueorangutan commented Jan 29, 2026

vishesh92 commented Aug 13, 2024 •

edited

Loading

codecov bot commented Aug 13, 2024 •

edited

Loading

sureshanaparti commented Aug 16, 2024 •

edited

Loading