Bnr resource limits

[Pearl1594]

Description

This PR addresses:

• backup retention in B&R scheduled backups #9621
• Part of Object Storage & Backup limits are missing #9642

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

Attention: Patch coverage is 3.70370% with 234 lines in your changes missing coverage. Please review.

Project coverage is 15.77%. Comparing base (046870e) to head (6646d63).
Report is 249 commits behind head on main.

Files with missing lines	Patch %	Lines
...rg/apache/cloudstack/backup/BackupManagerImpl.java	0.00%	79 Missing ⚠️
...main/java/org/apache/cloudstack/backup/Backup.java	0.00%	15 Missing ⚠️
...rg/apache/cloudstack/backup/dao/BackupDaoImpl.java	0.00%	12 Missing ⚠️
...main/java/com/cloud/api/query/vo/DomainJoinVO.java	0.00%	12 Missing ⚠️
...bernetes/cluster/KubernetesClusterManagerImpl.java	0.00%	10 Missing ⚠️
...pache/cloudstack/api/response/AccountResponse.java	0.00%	9 Missing ⚠️
...apache/cloudstack/api/response/DomainResponse.java	0.00%	9 Missing ⚠️
...pache/cloudstack/api/response/ProjectResponse.java	0.00%	9 Missing ⚠️
...rg/apache/cloudstack/backup/NASBackupProvider.java	0.00%	8 Missing ⚠️
...org/apache/cloudstack/backup/BackupScheduleVO.java	0.00%	7 Missing ⚠️
... and 15 more

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #9765      +/-   ##
============================================
- Coverage     15.78%   15.77%   -0.02%     
  Complexity    12552    12552              
============================================
  Files          5625     5625              
  Lines        491972   492423     +451     
  Branches      63764    59970    -3794     
============================================
+ Hits          77664    77683      +19     
- Misses       405849   406280     +431     
- Partials       8459     8460       +1     

Flag	Coverage Δ
uitests	4.03% <ø> (-0.01%)	⬇️
unittests	16.59% <3.70%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarqubecloud]

Quality Gate failed

Failed conditions
1.6% Coverage on New Code (required ≥ 40%)
21.3% Duplication on New Code (required ≤ 10%)
C Reliability Rating on New Code (required ≥ B)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[yadvr]

@Pearl1594 @abh1sar @rajujith can your review and advise if the other PR has already addressed this?

[levindecaro]

hi @Pearl1594 , I recently upgraded to version 4.20.1 and I’m hoping to find a way to enhance the bucket limit and bnr settings. It seems like these enhancement were dropped sometime ago, and I’m wondering if there’s any roadmap or plan to bring them back. Any information you can share would be greatly appreciated!

[abh1sar]

Hi @levindecaro, resource limit for backups and object storage was added to 4.20 via #10017
https://docs.cloudstack.apache.org/en/latest/adminguide/storage.html#configuring-resource-limits-on-buckets-and-object-storage-usage

[levindecaro]

Hi @abh1sar , I found the problem because the schema changes didn't update my existing database, my configuration table missing all the parameters from #10017 . I'd traced back the management.log since the upgrade, didn't found any related message of those parameters, is it missing from upgrade script ? i've no idea.

[levindecaro]

I can't found any INSERT statement from engine/schema/target/classes/META-INF/db/schema-* , am i missed in somewhere else?

[abh1sar]

@levindecaro sorry, my bad.
It will come in 4.21 not 4.20.