Skip to content

POOL-415 Add an option to JdkProxySource allowing to unwrap UndeclaredThrowableException#261

Merged
garydgregory merged 5 commits intoapache:masterfrom
Cosium:pool-415
May 7, 2025
Merged

POOL-415 Add an option to JdkProxySource allowing to unwrap UndeclaredThrowableException#261
garydgregory merged 5 commits intoapache:masterfrom
Cosium:pool-415

Conversation

@reda-alaoui
Copy link
Copy Markdown
Member

@reda-alaoui reda-alaoui commented Dec 6, 2023

@reda-alaoui
Copy link
Copy Markdown
Member Author

Up :)

Copy link
Copy Markdown
Member

@garydgregory garydgregory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @reda-alaoui

Thank you for your ping. Please see my comments.

Comment thread src/test/java/org/apache/commons/pool3/proxy/AbstractTestProxiedObjectPool.java Outdated
Comment thread src/test/java/org/apache/commons/pool3/proxy/AbstractTestProxiedObjectPool.java Outdated
@reda-alaoui reda-alaoui marked this pull request as draft April 18, 2025 14:20
@reda-alaoui reda-alaoui marked this pull request as ready for review April 18, 2025 14:21
@reda-alaoui reda-alaoui marked this pull request as draft April 18, 2025 14:30
@reda-alaoui reda-alaoui marked this pull request as ready for review April 18, 2025 14:40
@garydgregory
Copy link
Copy Markdown
Member

Hi @psteitz

Any thoughts on this request?

@psteitz
Copy link
Copy Markdown
Contributor

psteitz commented Apr 24, 2025

Looks good to me. Sorry for slow review response.

@reda-alaoui
Copy link
Copy Markdown
Member Author

Up :)

@garydgregory garydgregory merged commit 180e115 into apache:master May 7, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants