Add failing tests to reproduce POOL-426#451
Closed
rajucomp wants to merge 10 commits intoapache:POOL_2_Xfrom
rajucomp:POOL_2_X
Closed
Add failing tests to reproduce POOL-426#451rajucomp wants to merge 10 commits intoapache:POOL_2_Xfrom rajucomp:POOL_2_X
rajucomp wants to merge 10 commits intoapache:POOL_2_Xfrom
rajucomp:POOL_2_X
Conversation
Author
|
@garydgregory @psteitz Requesting critical review for the fix for POOL-426. Thanks! |
Member
|
Hi @psteitz Any thoughts on this one? |
Contributor
|
Analysis looks correct to me. This plus revert of bugged fix for POOL-425 should work. I am having trouble getting the patch applied to the right branch. Will review and merge once fully tested. Thanks for the patch. |
Member
|
I can cut a release candidate when we have a fix validated. |
Author
|
Added a test for POOL-413 as well. |
added 6 commits
December 25, 2025 19:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution to Apache Commons! Your help is appreciated!
Before you push a pull request, review this list:
mvn; that'smvnon the command line by itself.See https://issues.apache.org/jira/browse/POOL-426 for more details.