range-check the port for IPv6 hosts in isValidAuthority#412
Merged
Conversation
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IPv6 host port skips the range check in isValidAuthority
The port group in
AUTHORITY_PATTERNis captured the same way for a bracketed IPv6 host as for a hostname or IPv4 host, but the 0 to 65535 range check only ran in the hostname/IPv4 branch ofisValidAuthority. That left a gap:http://[::1]:99999/andhttp://[::1]:65536/validated as good while the equivalenthttp://127.0.0.1:99999/andhttp://example.com:99999/were correctly rejected, so an out-of-range port slipped through purely on the strength of the host being IPv6.Moved the existing port parse and range check out of that branch so both host forms are checked the same way. Valid ports such as
[::1]:65535and[::1]:80, and the no-port case, are unaffected. Added a regression test that fails without the change.