You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Deduplicate the TPC-H table schema across scheduler tests and benchmarks #2603
A schema change (for example a decimal precision change) has to be made in all three, and nothing checks that they stay the same.
Describe the solution you'd like
Expose a single tpch_schema(table) from one shared location that the scheduler tests and the benchmarks can both depend on, e.g. a ballista_core::test_utils::tpch module, or reuse an existing DataFusion TPC-H helper if one fits. Delete the three copies, and have get_tbl_tpch_table_schema derive from the shared function.
Describe alternatives you've considered
None.
Additional context
This is small and self-contained, a good first issue. Line references are pinned to commit ea1126c.
I'll move the schema into one shared helper that the scheduler tests and the tpch benchmark both use, delete the copies, and have get_tbl_tpch_table_schema build on it.
Activity
cestercian commentedon Oct 14, 2026
take
I'll move the schema into one shared helper that the scheduler tests and the tpch benchmark both use, delete the copies, and have get_tbl_tpch_table_schema build on it.
refactor: share one TPC-H schema across scheduler tests and benchmarks (