You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This repository has none. Agents working here have to work out how CI builds and tests the code, and they miss conventions that aren't visible from any single file.
Describe the solution you'd like
Add an AGENTS.md at the repository root, following the same pattern as the other DataFusion repositories, and symlink CLAUDE.md to it. Suggested content:
Targeted test runs: a single sqllogictest schedule (cargo test -p iceberg-sqllogictest --test sqllogictests -- <schedule>), and updating expect_test snapshots with UPDATE_EXPECT=1.
Conventions that are easy to miss: the workspace denies unused_qualifications, rustfmt uses max_width = 90, the toolchain version is pinned in both rust-toolchain.toml and .github/actions/setup-rust/action.yml, and new files need the ASF license header.
filter pushdown being Inexact, so a converted predicate may match extra rows but must never drop a matching one.
The sqllogictest harness: how schedules relate to .slt files, tables addressed as default.default.<table>, and EXPLAIN expectations that are updated by hand.
The iceberg-rust dependency: iceberg is pinned to a git revision, and DataFusion, iceberg-rust and Parquet must resolve to the same Arrow version.
The other repositories' AGENTS.md files tell agents to follow the PR template. This repository doesn't have one yet; adding one, e.g. copied from apache/datafusion, would let AGENTS.md do the same.
Is your feature request related to a problem or challenge?
Several DataFusion repositories have an
AGENTS.mdthat gives coding agents repository-specific instructions: apache/datafusion, apache/datafusion-comet, apache/datafusion-python and apache/datafusion-sqlparser-rs. The first three also symlinkCLAUDE.mdto it. apache/iceberg-rust has one as well, but it lives at the repository root, so it didn't move with this crate.This repository has none. Agents working here have to work out how CI builds and tests the code, and they miss conventions that aren't visible from any single file.
Describe the solution you'd like
Add an
AGENTS.mdat the repository root, following the same pattern as the other DataFusion repositories, and symlinkCLAUDE.mdto it. Suggested content:cargo fmt --all -- --check,cargo clippy --workspace --locked --all-targets -- -D warningsandcargo test --workspace --locked, plus the RAT license check once chore: add release infrastructure and rename crate back toiceberg-datafusion#32 lands.cargo test -p iceberg-sqllogictest --test sqllogictests -- <schedule>), and updatingexpect_testsnapshots withUPDATE_EXPECT=1.unused_qualifications, rustfmt usesmax_width = 90, the toolchain version is pinned in bothrust-toolchain.tomland.github/actions/setup-rust/action.yml, and new files need the ASF license header.INSERTpipeline (project_with_partition→repartition→sort_by_partition→IcebergWriteExec→IcebergCommitExec);Inexact, so a converted predicate may match extra rows but must never drop a matching one..sltfiles, tables addressed asdefault.default.<table>, andEXPLAINexpectations that are updated by hand.icebergis pinned to a git revision, and DataFusion, iceberg-rust and Parquet must resolve to the same Arrow version.Additional context
iceberg-datafusion#32, the file needs the ASF license header, as Comet's and iceberg-rust's have.AGENTS.mdfiles tell agents to follow the PR template. This repository doesn't have one yet; adding one, e.g. copied from apache/datafusion, would letAGENTS.mddo the same.