Skip to content

Add CI - #6

Merged
alamb merged 9 commits into
mainfrom
gabotechs/ci
Sep 22, 2026
Merged

alamb merged 9 commits into
mainfrom
gabotechs/ci

Conversation

@gabotechs

@gabotechs gabotechs commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Adds an ASF-compatible GitHub Actions baseline that checks formatting, Clippy, and the full workspace test suite on pull requests, main, and merge queues.

Rust setup and caching are centralized in a local action; dependency/build caches are restored for Clippy and tests and only saved from trusted main-branch runs. The PR also adds Dependabot coverage for Cargo and GitHub Actions (including local composite actions), an ASF action-allowlist check, and formats the existing code so the new format check passes.

@mbutrovich mbutrovich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabotechs thanks for getting CI going. Limiting cache writes to trusted pushes on main with save-if, together with persist-credentials: false and SHA-pinned third-party actions, is a good security baseline for a new ASF repo. I checked the pins against the ASF allowlist and they all pass: dtolnay/rust-toolchain@4cda84d5 is listed by SHA, Swatinem/rust-cache@* is allowed, and actions/* is trusted.

The comments below are about keeping CI results stable over time: which toolchain and rustfmt style CI enforces, and whether pushes to main can cancel each other.

The branch is one commit behind main (#5 renamed .asf.yml to .asf.yaml). There's no conflict, but required_status_checks.contexts in .asf.yaml is still empty, so these jobs won't be required to merge. Do you plan to add Format, Clippy, and Test there once this lands? If so, could you open an issue for it so it doesn't get lost?

Comment thread .github/actions/setup-rust/action.yml Outdated
Comment thread .github/workflows/ci.yml
Comment thread .github/workflows/ci.yml
Comment thread .github/workflows/ci.yml Outdated
@gabotechs

Copy link
Copy Markdown
Contributor Author

Do you plan to add Format, Clippy, and Test there once this lands? If so, could you open an issue for it so it doesn't get lost?

@mbutrovich I think we can actually do this now, unless you have a reason not to. Just added a commit for that.

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point in the repos live I think getting the CI up and running is key -- we can iterate quickly as the repo is still forming

Thank you @gabotechs and @mbutrovich

@alamb
alamb merged commit 05e277e into main Sep 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants