Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/verify-release-candidate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,10 @@ jobs:
arch: x64
runner: macos-15-intel

# Windows (disabled for now)
# - os: windows
# arch: x64
# runner: windows-latest
# Windows
- os: windows
arch: x64
runner: windows-latest
runs-on: ${{ matrix.runner }}
steps:
- name: Checkout repository
Expand Down
2 changes: 1 addition & 1 deletion dev/release/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ python3 -m twine upload --repository testpypi dist/datafusion-0.7.0.tar.gz

Before sending the vote email, run the manually triggered GitHub Actions workflow
"Verify Release Candidate" and confirm all matrix jobs pass across the OS/architecture matrix
(for example, Linux and macOS runners):
(for example, Linux, macOS, and Windows runners):

1. Go to https://github.com/apache/datafusion-python/actions/workflows/verify-release-candidate.yml
2. Click "Run workflow"
Expand Down
31 changes: 25 additions & 6 deletions dev/release/verify-release-candidate.sh
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,17 @@ test_source_distribution() {

curl https://sh.rustup.rs -sSf | sh -s -- -y --no-modify-path

export PATH=$RUSTUP_HOME/bin:$PATH
source $RUSTUP_HOME/env
# On Unix, rustup creates an env file. On Windows GitHub runners (MSYS bash),
# that file may not exist, so fall back to adding Cargo bin directly.
if [ -f "$CARGO_HOME/env" ]; then
# shellcheck disable=SC1090
source "$CARGO_HOME/env"
elif [ -f "$RUSTUP_HOME/env" ]; then
# shellcheck disable=SC1090
source "$RUSTUP_HOME/env"
else
export PATH="$CARGO_HOME/bin:$PATH"
fi

# build and test rust

Expand All @@ -126,10 +135,20 @@ test_source_distribution() {
git clone https://github.com/apache/parquet-testing.git parquet-testing

python3 -m venv .venv
source .venv/bin/activate
python3 -m pip install -U pip
python3 -m pip install -U maturin
maturin develop
if [ -x ".venv/bin/python" ]; then
VENV_PYTHON=".venv/bin/python"
elif [ -x ".venv/Scripts/python.exe" ]; then
VENV_PYTHON=".venv/Scripts/python.exe"
elif [ -x ".venv/Scripts/python" ]; then
VENV_PYTHON=".venv/Scripts/python"
else
echo "Unable to find python executable in virtual environment"
exit 1
fi

"$VENV_PYTHON" -m pip install -U pip
"$VENV_PYTHON" -m pip install -U maturin
"$VENV_PYTHON" -m maturin develop

#TODO: we should really run tests here as well
#python3 -m pytest
Expand Down