Merged
Conversation
Add build github workflow to produce python wheels for pypi
Contributor
Author
|
What are your thoughts on missing the windows wheel? I updated the comment to point to the trouble I had with it. Does this hold up |
Member
I don't think that lack of Windows support should hold up a 0.1.0 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added CI github action to build python wheels.
You can see a successful run of this action here the source branch for this PR: https://github.com/robtandy/datafusion-ray/actions/runs/13680781621
In this PR, the
build.ymlgithub action will build wheels for:Notably missing here is a windows wheel. It should be addressed in a subsequent, in my opinion, PR as there is complexity around using the
protobuf-srccrate on the build machine as can be seen here: https://github.com/robtandy/datafusion-ray/actions/runs/13680113339/job/38250064986. I'm not sure if this should hold up the release, but i personally think no.Structuring our developer workflow similar to datafusion-python has paid off as we were able to use a lot of their
build.ymlwhere the complexity came in was building for many linux and figuring out how to add a protobuf compiler into those cross comp docker images. Ultimately, it meant downloading and executing a release build of protoc.It should address another of the items in the #2 checklist