feat: implement PhysicalOptimizerRule in FFI crate#20451
Draft
timsaucer wants to merge 7 commits intoapache:mainfrom
Draft
feat: implement PhysicalOptimizerRule in FFI crate#20451timsaucer wants to merge 7 commits intoapache:mainfrom
timsaucer wants to merge 7 commits intoapache:mainfrom
Conversation
github-actions
bot
added
documentation
timsaucer
force-pushed
the
feat/ffi-plan-optimizer
branch
from
00ef9d6 to
5072a54
Compare
github-actions
bot
removed
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT: Requires rebase after #20449 merges
Which issue does this PR close?
Rationale for this change
This PR is a pure addition to implement a FFI safe PhysicalOptimizerRule. With this change downstream projects, such as
datafusion-pythoncan share optimizer rules across libraries.What changes are included in this PR?
Implement physical optimizer rule following same pattern as the rest of the FFI crate.
Are these changes tested?
TODO add unit and integration tests
Are there any user-facing changes?
None