Conversation
This was referenced Aug 27, 2026
xavlee
force-pushed
the
test/issue-24438-group-contiguous-single-partition
branch
from
August 27, 2026 19:16
61c082c to
060dd38
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24737 +/- ##
==========================================
- Coverage 82.45% 82.44% -0.01%
==========================================
Files 1140 1140
Lines 436434 436492 +58
Branches 436434 436492 +58
==========================================
+ Hits 359840 359879 +39
- Misses 54840 54848 +8
- Partials 21754 21765 +11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
xavlee
force-pushed
the
test/issue-24438-group-contiguous-single-partition
branch
from
August 27, 2026 20:54
060dd38 to
3b6d7ab
Compare
gene-bordegaray
approved these changes
Aug 31, 2026
gene-bordegaray
left a comment
Contributor
There was a problem hiding this comment.
approved with some suggstions for displaying expected behavior
xavlee
force-pushed
the
test/issue-24438-group-contiguous-single-partition
branch
from
August 31, 2026 17:50
3b6d7ab to
5dfc10b
Compare
gene-bordegaray
approved these changes
Aug 31, 2026
xudong963
approved these changes
Sep 3, 2026
xavlee
force-pushed
the
test/issue-24438-group-contiguous-single-partition
branch
3 times, most recently
from
September 7, 2026 20:23
7100fae to
fef01ed
Compare
xavlee
force-pushed
the
test/issue-24438-group-contiguous-single-partition
branch
from
September 16, 2026 14:24
fef01ed to
0e9cafe
Compare
Contributor
|
rebumping this, just went over again and looks good. |
xavlee
force-pushed
the
test/issue-24438-group-contiguous-single-partition
branch
from
September 22, 2026 17:44
0e9cafe to
7ba0a9b
Compare
xavlee
force-pushed
the
test/issue-24438-group-contiguous-single-partition
branch
from
September 23, 2026 02:04
7ba0a9b to
36969e7
Compare
xavlee
marked this pull request as ready for review
September 23, 2026 19:30
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR relate to?
Rationale for this change
A source can concatenate several sorted logical runs into one DataFusion output partition. The resulting stream may be globally unsorted while every distinct
(key, time_bin)tuple still occupies one contiguous range.This PR records how aggregate planning handles that layout before grouped input properties are available. It provides the behavioral baseline for the remaining PRs in the stack.
What changes are included in this PR?
TestMemoryExecfixture containing two sorted logical runs whose(key, time_bin)order resets at the record-batch boundary.(key, time_bin)tuple and verify the result.InputOrderMode::Linear,EmissionType::Final, andSingleHashAggregateStream.Stack
Are these changes tested?
The new aggregate test executes the single-partition input and snapshot-checks all four grouped sums.
Are there any user-facing changes?
No.
Review this layer
View only this PR layer