Repository navigation
test: consolidate ASOF SQL coverage - #24964
Conversation
# Conflicts: # datafusion/expr/src/logical_plan/builder.rs # datafusion/expr/src/logical_plan/plan.rs
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24964 +/- ##
==========================================
- Coverage 82.69% 82.69% -0.01%
==========================================
Files 1147 1147
Lines 447348 447348
Branches 447348 447348
==========================================
- Hits 369936 369927 -9
- Misses 54999 55006 +7
- Partials 22413 22415 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Hi @jayzhan211 and @2010YOUY01, this ASOF test coverage follow-up is now restacked and ready for review. Would you mind taking a look when you have time? Thanks! |
|
This test only passes because -# SELECT * exposes the USING key once.
+# SELECT * exposes the USING key once, keeping the key whose qualifier sorts
+# first (`l` < `r` keeps the left key).# With the right alias sorting first, SELECT * keeps the right key, which is
# NULL for unmatched left rows.
query IPTPT
SELECT *
FROM asof_left x
ASOF JOIN asof_right a
MATCH_CONDITION (x.ts >= a.ts)
USING (grp)
WHERE x.id IN (1, 2)
ORDER BY x.id;
----
1 2024-01-01T09:00:01 NULL NULL NULL
2 2024-01-01T09:00:04 A 2024-01-01T09:00:04 a4 |
|
@jayzhan211 nice catch! Will fix. |
Which issue does this PR close?
Rationale for this change
ASOF SQL behavior was split between sqllogictest and Rust integration tests. SQL-visible results and plan shapes are easier to review and maintain in SLT, while Rust coverage remains useful for execution setup that SLT cannot express.
What changes are included in this PR?
USINGoutput, and validation coverage intoasof_join.slt.USING.Are these changes tested?
Yes:
cargo fmt --all -- --checkcargo clippy --all-targets --all-features -- -D warningscargo test --profile ci -p datafusion-sqllogictest --test sqllogictests -- asof_joincargo test --profile ci -p datafusion --test core_integration --all-features -- asofAre there any user-facing changes?
No. This consolidates and expands coverage for the existing ASOF SQL contract.