Repository navigation
Make TopKDynamicFilters public - #25429
Merged
Merged
Conversation
This is needed as an argument to `TopK::try_new()`, so without it it's impossible to construct a `TopK`.
masonh22
added a commit
to coralogix/arrow-datafusion
that referenced
this pull request
Sep 17, 2026
Upstream PR: apache#25429
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25429 +/- ##
==========================================
+ Coverage 82.72% 82.73% +0.01%
==========================================
Files 1147 1147
Lines 448013 449540 +1527
Branches 448013 449540 +1527
==========================================
+ Hits 370602 371916 +1314
- Misses 54920 54947 +27
- Partials 22491 22677 +186 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
masonh22
marked this pull request as ready for review
September 21, 2026 17:05
masonh22
added a commit
to coralogix/arrow-datafusion
that referenced
this pull request
Sep 21, 2026
Upstream PR: apache#25429
kosiew
approved these changes
Oct 9, 2026
kosiew
left a comment
kosiew
left a comment
Contributor
There was a problem hiding this comment.
Thanks for addressing the earlier feedback. The crate-root re-export makes TopKDynamicFilters accessible to downstream consumers, and the new rustdoc example provides regression coverage for the public import path and TopK::try_new construction.
All previous comments have been addressed, and I found no new issues in the follow-up changes. LGTM!
Contributor
|
🚀 |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Omega359
pushed a commit
to Omega359/arrow-datafusion
that referenced
this pull request
Oct 11, 2026
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - Closes #. ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. Please explain the problem you are trying to solve in terms of the user-visible behavior, rather than the implementation. For example, "The code in `foo.rs` doesn't handle nulls" is a symptom of the implementation. "COUNT(DISTINCT) returns wrong results when the column contains nulls" is the user-visible problem. --> `TopKDynamicFilters` is needed as an argument to `TopK::try_new()`, so without it it's impossible to construct a `TopK`. ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here, but it is sometimes worth providing a summary of the individual changes in this PR. --> ## What is the testing strategy for this PR? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code Briefly describe how this PR is tested, and point to the specific tests you added. For example: 'This new feature is covered by the `sqllogictest` cases added in `foo.slt`'. If this PR does not add tests, explain why. For example, if the change is already covered by existing tests, please mention it. You should also check the `codecov` bot reply on this PR to confirm the changed code is exercised. --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please add the `api change` label. --> --------- Co-authored-by: kosiew <kosiew@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
TopKDynamicFiltersis needed as an argument toTopK::try_new(), so without it it's impossible to construct aTopK.What changes are included in this PR?
What is the testing strategy for this PR?
Are there any user-facing changes?