Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25599 +/- ##
==========================================
- Coverage 82.42% 82.42% -0.01%
==========================================
Files 1138 1139 +1
Lines 435501 435483 -18
Branches 435501 435483 -18
==========================================
- Hits 358955 358927 -28
- Misses 54841 54843 +2
- Partials 21705 21713 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
@lyne7-sc |
Contributor
Author
kosiew
marked this pull request as draft
October 15, 2026 09:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
TopK queries with frequent heap replacements spend time capturing evicted rows that ordinary TopK and partitioned
ROW_NUMBERTopK immediately discard. Avoiding this work reduces allocation, encoded-key copying, and RecordBatch column-reference cloning.What changes are included in this PR?
add()andadd_with_eviction(), sharing heap maintenance through a const-generic implementation.What is the testing strategy for this PR?
test_topk_heap_same_and_cross_batch_evictionto cover both capture and discard modes, checking evicted values, encoded keys, batch release, and final output.topk.sltandwindow_topn.sltverifies ordinary TopK and partitionedROW_NUMBER/RANKbehavior.Are there any user-facing changes?
This is an internal performance improvement. Query results and public APIs are unchanged.
Benchmarks