docs: clarify what PushedDown::Yes and PushedDown::No mean - #25670
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25670 +/- ##
==========================================
+ Coverage 82.48% 82.51% +0.02%
==========================================
Files 1140 1140
Lines 437614 438443 +829
Branches 437614 438443 +829
==========================================
+ Hits 360986 361763 +777
- Misses 54834 54836 +2
- Partials 21794 21844 +50 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
adriangb
force-pushed
the
pushed-down-no-docs
branch
from
September 24, 2026 16:27
64137bf to
c620746
Compare
adriangb
changed the title
PushedDown::No means for filter pushdownPushedDown::Yes and PushedDown::No mean
Contributor
Author
|
FYI @jayzhan211 I toned it down a bit about implementation details and that |
`PushedDown::Yes` means the child applies the predicate exactly, so the parent does not need to evaluate it again. `PushedDown::No` means the parent must still evaluate it. A child that replies `No` can still use the filter in an inexact way, for example for statistics pruning. Document this. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
adriangb
force-pushed
the
pushed-down-no-docs
branch
from
September 24, 2026 16:33
c620746 to
b0a974a
Compare
diegoQuinas
pushed a commit
to diegoQuinas/datafusion
that referenced
this pull request
Sep 24, 2026
…e#25670) ## Which issue does this PR close? - Related to apache#18856 and apache#24528. This PR does not change the API. It only documents the two states that exist. ## Rationale for this change The docs say `PushedDown::No` means "the predicate could not be pushed down into the child node". This reads as "the child ignores the filter". But a child that replies `No` can still use the filter, for example for statistics pruning. ## What changes are included in this PR? Doc comments on `PushedDown`: | Reply | Must the parent evaluate the filter? | Can the child use the filter? | |---|---|---| | `Yes` | No. The child applies it exactly. | Yes, exactly | | `No` | Yes | Yes, in an inexact way (for example statistics pruning), or not at all | ## What is the testing strategy for this PR? Documentation only. `cargo doc -p datafusion-physical-plan` builds with `-D warnings`. ## Are there any user-facing changes? No. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The docs say
PushedDown::Nomeans "the predicate could not be pushed down into the child node". This reads as "the child ignores the filter". But a child that repliesNocan still use the filter, for example for statistics pruning.What changes are included in this PR?
Doc comments on
PushedDown:YesNoWhat is the testing strategy for this PR?
Documentation only.
cargo doc -p datafusion-physical-planbuilds with-D warnings.Are there any user-facing changes?
No.
🤖 Generated with Claude Code