Skip to content

docs: fix malformed rustdoc for bit_and/bit_or/bit_xor expr fns #25997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jackylee-ch wants to merge 1 commit into from
Closed

docs: fix malformed rustdoc for bit_and/bit_or/bit_xor expr fns #25997

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions datafusion/functions-aggregate/src/bit_and_or_xor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,17 +115,14 @@ macro_rules! downcast_bitwise_accumulator {
/// `EXPR_FN` identifier used to name the generated expression function.
/// `AGGREGATE_UDF_FN` is an identifier used to name the underlying UDAF function.
/// `OPR_TYPE` is an expression that evaluates to the type of bitwise operation to be performed.
/// `OPR_NAME` is a string literal naming the operation in the generated expression function's docs (e.g. `"AND"`).
/// `DOCUMENTATION` documentation for the UDAF
macro_rules! make_bitwise_udaf_expr_and_func {
($EXPR_FN:ident, $AGGREGATE_UDF_FN:ident, $OPR_TYPE:expr, $DOCUMENTATION:expr) => {
($EXPR_FN:ident, $AGGREGATE_UDF_FN:ident, $OPR_TYPE:expr, $OPR_NAME:literal, $DOCUMENTATION:expr) => {
make_udaf_expr!(
$EXPR_FN,
expr_x,
concat!(
"Returns the bitwise",
stringify!($OPR_TYPE),
"of a group of values"
),
concat!("Returns the bitwise ", $OPR_NAME, " of a group of values"),
$AGGREGATE_UDF_FN
);
create_func!(
Expand Down Expand Up @@ -182,18 +179,21 @@ make_bitwise_udaf_expr_and_func!(
bit_and,
bit_and_udaf,
BitwiseOperationType::And,
"AND",
get_bit_and_doc()
);
make_bitwise_udaf_expr_and_func!(
bit_or,
bit_or_udaf,
BitwiseOperationType::Or,
"OR",
get_bit_or_doc()
);
make_bitwise_udaf_expr_and_func!(
bit_xor,
bit_xor_udaf,
BitwiseOperationType::Xor,
"XOR",
get_bit_xor_doc()
);

Expand Down
Loading