Repository navigation
feat: add Nix flake and direnv support - #26005
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #26005 +/- ##
==========================================
- Coverage 82.64% 82.64% -0.01%
==========================================
Files 1147 1147
Lines 445502 445502
Branches 445502 445502
==========================================
- Hits 368179 368169 -10
- Misses 54969 54974 +5
- Partials 22354 22359 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kumarUjjawal
approved these changes
Oct 4, 2026
kumarUjjawal
left a comment
Contributor
There was a problem hiding this comment.
Thank you @VVKot
The changes look good to me
Contributor
Author
|
@kumarUjjawal are we good to merge here then? |
Contributor
Yes, thank you for the ping. |
Contributor
|
Thank you @VVKot for your contribution! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Happy to file an issue if needed!
Rationale for this change
DataFusion requires protobuf and OpenSSL installations to compile. Existing instructions only cover FHS-compliant systems.
What changes are included in this PR?
What is the testing strategy for this PR?
I have confirmed DataFusion now successfully compiles without having protobuf or OpenSSL installed globally. Would appreciate confirmation that this also works for other Nix[OS] developers!
Are there any user-facing changes?
No.
Other considerations
I chose to track the stable channel to minimize the risk of flake breaking. I chose to check-in the flake lock for reproducibility - note that this means it will need to be periodically bumped.
This flake could be further extend to include other "supporting" packages that DataFusion relies on for development, such as
uv-- omitted those for simplicity of the PR / to not have to decide what goes into flake VS not now.I appreciate this is yet another developer-facing file that needs to be maintained, and the project already has a devcontainer setup. However, this provides a quick start for all developers using Nix[OS], without forcing them to accept overhead of a Docker container, or figuring out the native libraries installation themselves.
If nothing else -- every time I
git clonea project that has flake + direnv integration and automatically sets up a Nix shell that "just works", it makes my day a little bit and makes me that much more likely to consider contributing. :) I want the same experience for all (future) DataFusion contributors out there!