fix: Unparse random as rand for some dialects - #26009
Open
nuno-faria wants to merge 3 commits into
Open
nuno-faria wants to merge 3 commits into
nuno-faria wants to merge 3 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26009 +/- ##
========================================
Coverage 82.64% 82.65%
========================================
Files 1147 1147
Lines 445502 446113 +611
Branches 445502 446113 +611
========================================
+ Hits 368179 368720 +541
- Misses 54969 54999 +30
- Partials 22354 22394 +40 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
VVKot
approved these changes
Oct 3, 2026
|
@nuno-faria maybe link inline to the MySQL/BigQuery docs describing their syntax? |
Contributor
Author
Good idea @VVKot, added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
randomfunction generates invalid SQL for some dialects #26008.Rationale for this change
Generate valid SQL for the dialects that do not support the
random()functionWhat changes are included in this PR?
What is the testing strategy for this PR?
Unit test.
Are there any user-facing changes?
No.