docs: explain date_bin daylight saving behavior - #26041
Open
Prajwal-k-tech wants to merge 1 commit into
Open
Prajwal-k-tech wants to merge 1 commit into
Prajwal-k-tech wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
date_binwith an explicit origin drifts an hour across a DST transition #25168Rationale for this change
An explicit
date_binorigin anchors buckets to an instant. For timezone-aware timestamps, an origin aligned with local midnight can therefore move to 01:00 after a daylight saving transition. The issue confirms this behavior matches PostgreSQL and DuckDB; the missing piece is documenting the tradeoff and the local-time alternatives.What changes are included in this PR?
date_binuses a fixed origin and does not adjust it for daylight saving changes.date_truncfor calendar units and toto_local_timefor binning other intervals against local wall-clock boundaries.This PR was prepared with AI assistance. The source change, generated reference, issue reproductions, and project checks were reviewed for consistency.
What is the testing strategy for this PR?
This is a documentation-only change, so no runtime tests were added. Verified generated docs with
./dev/update_function_docs.shand./ci/scripts/check_generated_docs.sh; also rancargo +1.99.0 fmt --all -- --check,cargo clippy --all-targets --all-features -- -D warnings,./ci/scripts/doc_prettier_check.sh --write --allow-dirty, andgit diff --check.Are there any user-facing changes?
Yes. The
date_binreference now explains fixed-origin behavior across DST and documents alternatives for local calendar boundaries.