Repository navigation
fix: avoid shifting zero grouping ordinals by 64 - #26136
Open
alexandrefimov wants to merge 1 commit into
Open
alexandrefimov wants to merge 1 commit into
alexandrefimov wants to merge 1 commit into
Conversation
A unique 64-column grouping set fits the UInt64 representation, but packing its zero duplicate ordinal shifts by the full width. Use the semantic mask directly for ordinal zero and preserve the existing capacity checks for nonzero ordinals. Add unit boundary tests and SQL coverage for both aggregate kernels, including real NULL keys, duplicate sets and capacity refusals.
github-actions
Bot
added
sqllogictest
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26136 +/- ##
=======================================
Coverage 82.74% 82.74%
=======================================
Files 1147 1147
Lines 449767 449807 +40
Branches 449767 449807 +40
=======================================
+ Hits 372157 372209 +52
+ Misses 54942 54932 -10
+ Partials 22668 22666 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #26134.
Rationale for this change
A representable 64-column grouping-set query can panic while constructing its grouping ID.
What changes are included in this PR?
Use the semantic mask directly when the duplicate ordinal is zero. Preserve the existing checks for layouts requiring more than 64 bits.
What is the testing strategy for this PR?
Four unit boundary tests plus SQL coverage for both aggregate kernels, real versus rolled-up NULLs, duplicate sets and capacity refusals.
Focused tests, crate tests, extended workspace tests, formatting, all-target/all-feature Clippy and
dev/rust_lint.shpassed.Are there any user-facing changes?
Valid 64-column grouping sets execute successfully. Unrepresentable layouts continue to return NotImplemented.