Skip to content

perf: add a GroupsAccumulator for array_agg(DISTINCT) #26357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhuqi-lucas wants to merge 4 commits into
base: main
Choose a base branch
from
+840 −69
Open

perf: add a GroupsAccumulator for array_agg(DISTINCT) #26357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bb42f07
perf: add a GroupsAccumulator for array_agg(DISTINCT)
zhuqi-lucas Oct 15, 2026
4ee655c
Record DISTINCT metrics and encode only selected values in array_agg(…
zhuqi-lucas Oct 15, 2026
d29b125
Merge branch 'main' into array-agg-distinct-groups-accumulator
zhuqi-lucas Oct 16, 2026
5e25666
Estimate pair_set memory with estimate_memory_size
zhuqi-lucas Oct 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion datafusion/core/tests/sql/aggregates/nested_nullability.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,8 @@ async fn array_agg_struct_from_stricter_batches_with_spilling() -> Result<()> {
#[tokio::test]
async fn array_agg_distinct_struct_from_stricter_batches_with_spilling() -> Result<()> {
AggregateBatchesTest::new()
.with_num_rows(10_000)
// Enough groups that even the compact native accumulator exceeds the limit
.with_num_rows(100_000)
// One partition keeps the native aggregate's memory pressure deterministic.
.with_target_partitions(1)
.without_single_distinct_to_groupby()
Expand Down
Loading
Loading