Repository navigation
refactor: extract aggregate physical planning - #26403
Merged
2010YOUY01 merged 1 commit intoOct 16, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26403 +/- ##
=======================================
Coverage 82.87% 82.87%
=======================================
Files 1153 1153
Lines 457101 457124 +23
Branches 457101 457124 +23
=======================================
+ Hits 378818 378841 +23
+ Misses 55268 55267 -1
- Partials 23015 23016 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2010YOUY01
approved these changes
Oct 16, 2026
2010YOUY01
left a comment
Contributor
There was a problem hiding this comment.
Thank you!
I've let AI checked this logic has been moved without change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
DefaultPhysicalPlanner::map_logical_node_to_physicalcontains the complete aggregate planning implementation inline. Moving this arm behind a focused method makes the top-level logical-plan dispatcher easier to navigate and reduces conflict pressure around planner changes.What changes are included in this PR?
This PR extracts only the
Aggregatearm into a privateplan_aggregatemethod. Schema validation, grouping expression lowering, async expression planning, repartition selection, and partial/final aggregate construction are unchanged.What is the testing strategy for this PR?
cargo test -p datafusion --lib physical_planner::testscargo clippy -p datafusion --all-targets --all-features -- -D warningscargo fmt --all -- --checkgit diff --checkThe existing physical planner tests cover aggregate schema checks, grouping sets, repartitioning, aliases, and scalar subqueries; no new behavior is introduced.
Are there any user-facing changes?
No. This is an internal refactor with no public API or behavior change.