Skip to content

Updating generated licenses#10

Open
lee-rvt wants to merge 1 commit intoapache:masterfrom
RivianVW-tech:license-generation
Open

Updating generated licenses#10
lee-rvt wants to merge 1 commit intoapache:masterfrom
RivianVW-tech:license-generation

Conversation

@lee-rvt
Copy link

@lee-rvt lee-rvt commented Mar 13, 2026

Fixes #XXXX.

Description

This updates generated files that have cosmetic changes due to previous license update.

This PR has:

  • been tested on a real K8S cluster to ensure creation of a brand new Druid cluster works.
  • been tested for backward compatibility on a real K*S cluster by applying the changes introduced here on an existing Druid cluster. If there are any backward incompatible changes then they have been noted in the PR description.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

Key changed/added files in this PR

New license notices.

@razinbouzar
Copy link
Contributor

razinbouzar commented Mar 13, 2026

thank you @lee-rvt. this lgtm just a couple of observations:

  1. Verified that zz_generated.deepcopy.go is already excluded from rat runs.
  2. Should apis/druid/v1alpha1/groupversion_info.go, apis/druid/v1alpha1/doc.go, and controllers/druid/suite_test.go also be updated?

@lee-rvt
Copy link
Author

lee-rvt commented Mar 13, 2026

  1. That's a good question. This is just the diffs I found after taking a clean tree and running make once. I also ran make test but that didn't change the diff. if those files aren't being generated/modified by make, I'm not sure why they need to be updated?

@razinbouzar
Copy link
Contributor

  1. Just a nit for consistency and not needed!

@abhishekrb19 / @AdheipSingh can either of you trigger a workflow run for this and review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants