Console: Improve cancellation in current-dart-panel.#19182
Open
gianm wants to merge 2 commits intoapache:masterfrom
Open
Console: Improve cancellation in current-dart-panel.#19182gianm wants to merge 2 commits intoapache:masterfrom
gianm wants to merge 2 commits intoapache:masterfrom
Conversation
Two improvements: 1) Only show "Cancel query" if the query is ACCEPTED or RUNNING. 2) Cancellation can sometimes return 404 even when successful if there are multiple Brokers. It can also return 404 if the query finished before it could be canceled. Neither of these really deserve a "danger" toast. Change to a success toast with text "Query canceled or no longer running".
gianm
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two improvements:
Only show "Cancel query" if the query is ACCEPTED or RUNNING.
Cancellation can sometimes return 404 even when successful if there
are multiple Brokers. It can also return 404 if the query finished
before it could be canceled. Neither of these really deserve a
"danger" toast. Change to a success toast with text "Query canceled
or no longer running".