Console: Show Dart sqlQueryId in details pane.#19185
Merged
gianm merged 1 commit intoapache:masterfrom Mar 20, 2026
Merged
Conversation
Show both the unique execution ID (dartQueryId) and the potentially sqlQueryId. This is useful when the sqlQueryId is user-provided and meaningful, and is also useful for correlating with SQL query logs.
capistrant
approved these changes
Mar 20, 2026
Contributor
capistrant
left a comment
capistrant
left a comment
There was a problem hiding this comment.
non-blocking suggestion that you can take or leave. overall nice addition
| {execution.sqlQueryId && ( | ||
| <> | ||
| {' '} | ||
| (SQL ID <Tag minimal>{execution.sqlQueryId}</Tag>) |
Contributor
There was a problem hiding this comment.
nit. I have no strong preference either way, but maybe keeping the "query" context would be good UX?
Suggested change
| (SQL ID <Tag minimal>{execution.sqlQueryId}</Tag>) | |
| (SQL QUERY ID <Tag minimal>{execution.sqlQueryId}</Tag>) |
Contributor
Author
There was a problem hiding this comment.
I was trying to keep the label short, hopefully it's clear enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show both the unique execution ID (
dartQueryId) and thesqlQueryId. This is useful when thesqlQueryIdis user-provided and meaningful, and is also useful for correlating with SQL query logs.