Clean up deep storage after index parallel merge finishes #19187
Open
GWphua wants to merge 10 commits intoapache:masterfrom
Open
Clean up deep storage after index parallel merge finishes #19187GWphua wants to merge 10 commits intoapache:masterfrom
GWphua wants to merge 10 commits intoapache:masterfrom
Conversation
Add delete for datasegments Unit Tests and Embedded tests Cleanup
| * may be null or empty if phase 1 produced no output. | ||
| */ | ||
| @VisibleForTesting | ||
| static void cleanupDeepStorageShuffleData( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19163
Description
In the context of multi-phase index_parallel tasks, intermediary files created onto deep storage are not being cleaned up.
Fixed the issue by triggering deepstore intermediary-data cleanup from the supervisor task after the merge in phase 2 completes.
Release note
Introduced a mechanism to automatically clean up intermediary files on Deep Storage.
Key changed/added classes in this PR
ParallelIndexSupervisorTaskThis PR has: