-
Notifications
You must be signed in to change notification settings - Fork 26.6k
Fix issue 15678 Key no longer appear in exception messages #15812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
qxggg
wants to merge
10
commits into
apache:3.3
Choose a base branch
from
qxggg:fix-issue-15678
base: 3.3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+80
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #15812 +/- ##
=========================================
Coverage 60.77% 60.78%
- Complexity 11710 11721 +11
=========================================
Files 1938 1938
Lines 88692 88707 +15
Branches 13387 13391 +4
=========================================
+ Hits 53903 53917 +14
+ Misses 29260 29254 -6
- Partials 5529 5536 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
see #15678
This change introduces support for masking sensitive parameters when building URL strings in Dubbo.
Previously, parameters such as password, secretKey, or other user-defined sensitive fields could be exposed in logs or configuration outputs.
The update ensures that:
1. Sensitive parameter names can be configured through
dubbo.url.sensitive-parameter-names.
2. Any parameter matching the sensitive list is automatically excluded when the URL string is generated.
3. The behavior is covered by unit tests, ensuring consistent functionality and preventing regressions.
Checklist