Skip to content

Conversation

@bowenli86
Copy link
Member

What is the purpose of the change

(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)

Brief change log

(for example:)

  • The TaskInfo is stored in the blob store on job creation time as a persistent artifact
  • Deployments RPC transmits only the blob storage reference
  • TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change

Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (100MB)
  • Extended integration test for recovery after master (JobManager) failure
  • Added test that validates that TaskInfo is transferred only once across recoveries
  • Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 16, 2026

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@bowenli86
Copy link
Member Author

bowenli86 commented Jan 16, 2026

realized i submitted from a wrong inrepo branch so i recreated pr from my fork and deleted that branch, but it seems to accidentally delete all conversations

@davidradl @ferenc-csaky we can restart python related convo here

re: why these python tests are still in main repo - AFAIK there was an attempt to migrate py connectors to each connector repo, but it's left half way done and never finished, so all py connector artifacts like kafka.py are still published from main repo, not connector repo. It will be the best if Confluent can help fix the broken state

@bowenli86 bowenli86 changed the title [hotfix] re-enable unit tests in pyflink test_kafka.py [hotfix] re-enable unit tests test_kafka.py for pyflink Jan 16, 2026
@bowenli86
Copy link
Member Author

hmmm why CIs are not run for this pr

@davidradl
Copy link
Contributor

@bowenli86 - I see the CI ran and failed - including a failure in test_ci python.

@davidradl
Copy link
Contributor

re: why these python tests are still in main repo - AFAIK there was an attempt to migrate py connectors to each connector repo, but it's left half way done and never finished, so all py connector artifacts like kafka.py are still published from main repo, not connector repo. It will be the best if Confluent can help fix the broken state

I suggest it could be anyone in the community not just Confluent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants