[FLINK-38913][table-planner] ArrayIndexOutOfBoundsException unparsing CAST. #27431
+65
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arsing CAST Signed-off-by: davidradl <david_radley@uk.ibm.com>
Collaborator
snuyanzin
reviewed
Jan 17, 2026
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| /** Tests for {@link SqlTypeUtil}. */ | ||
| class SqlTypeUtilTest { |
Contributor
There was a problem hiding this comment.
if the issue is fixed in parser, can we have tests in parser?
snuyanzin
reviewed
Jan 17, 2026
| } | ||
| if (comments.get(i) != null) { | ||
| // With bounds check - prevents IndexOutOfBoundsException | ||
| if (i < comments.size() && comments.get(i) != null) { |
Contributor
There was a problem hiding this comment.
is the logic correctly working if some fields is the middle without comments and fields in the beginning and end are with comments?
Contributor
There was a problem hiding this comment.
probably also need a test for that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The table planner gets an ArrayIndexOutOfBoundsException while unparsing a CAST. The error occurs here
due to an empty comments list being passed here) )
Normally this code would have null elements for each field as per the grammarshows).
The change is to bounds check to ensure that there is a comments element before addressing it.
The rejected alternative is to fill the list with nulls in the caller for the failing case.
Brief change log
Verifying this change
Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.
This change added tests and can be verified as follows:
added a unit test, this had to be in the table planner, as the parser unit tests added the commnets as per the grammar, so were not testing the fix.
can be verified in the SQL client by issuing
"CREATE TABLE orders (
) WITH (
'connector' = 'filesystem',
'path' = 'file:///Users/davidradley/bashscripts/sqlscripts/json/test_avro.json',
'format' = 'avro'
);"
Prior to the fix this get the ArrayIndexOutOfBoundsException
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation