[lake] Support partition mark-done for lakehouse tiering (processing-time) - #3635
Open
beryllw wants to merge 2 commits into
Open
[lake] Support partition mark-done for lakehouse tiering (processing-time)#3635beryllw wants to merge 2 commits into
beryllw wants to merge 2 commits into
Conversation
beryllw
marked this pull request as draft
July 11, 2026 10:39
beryllw
force-pushed
the
feature/paimon-markdone
branch
from
July 15, 2026 15:18
e565147 to
5355d56
Compare
beryllw
force-pushed
the
feature/paimon-markdone
branch
from
August 4, 2026 03:54
5355d56 to
aee9f7b
Compare
beryllw
marked this pull request as ready for review
August 4, 2026 03:55
beryllw
force-pushed
the
feature/paimon-markdone
branch
2 times, most recently
from
August 4, 2026 08:52
7eb2246 to
ce275c1
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds partition mark-done support for Paimon lakehouse tiering in the Fluss tiering service, including the ability to run a “maintenance” round when a tiering cycle produces no data, and to persist mark-done tracking state in Paimon snapshot properties.
Changes:
- Implement Paimon partition mark-done logic (state model + trigger + action execution) and persist state via snapshot properties.
- Extend the Flink tiering pipeline to emit an empty “skip-round” split and commit mark-done maintenance on empty rounds when enabled.
- Add UT/IT coverage for the mark-done lifecycle, cold start backfill, and late-data behavior.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| fluss-lake/fluss-lake-paimon/src/test/java/org/apache/fluss/lake/paimon/tiering/PaimonTieringITCase.java | Adds an IT case validating end-to-end partition mark-done behavior (including _SUCCESS and snapshot properties). |
| fluss-lake/fluss-lake-paimon/src/test/java/org/apache/fluss/lake/paimon/tiering/PaimonPartitionMarkDoneTest.java | New UT covering mark-done state lifecycle, cold start backfill, end-time guarding, and JSON serde behavior. |
| fluss-lake/fluss-lake-paimon/src/main/java/org/apache/fluss/lake/paimon/tiering/PartitionMarkDoneTrigger.java | New trigger (adapted from Paimon) to decide which partitions are idle enough to be marked done. |
| fluss-lake/fluss-lake-paimon/src/main/java/org/apache/fluss/lake/paimon/tiering/PaimonPartitionMarkDone.java | New core implementation that tracks tiered partitions, performs idle judgment, and runs Paimon mark-done actions. |
| fluss-lake/fluss-lake-paimon/src/main/java/org/apache/fluss/lake/paimon/tiering/PaimonLakeTieringFactory.java | Declares Paimon supports mark-done via the new capability interface. |
| fluss-lake/fluss-lake-paimon/src/main/java/org/apache/fluss/lake/paimon/tiering/PaimonLakeCommitter.java | Runs mark-done on data commits and implements maintenance commits for empty rounds via properties-only snapshots. |
| fluss-lake/fluss-lake-paimon/src/main/java/org/apache/fluss/lake/paimon/tiering/MarkDoneStateJsonSerde.java | New JSON serde for persisted mark-done state in snapshot properties. |
| fluss-lake/fluss-lake-paimon/src/main/java/org/apache/fluss/lake/paimon/tiering/MarkDoneState.java | New state model representing cold-start initialization and pending partitions. |
| fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/tiering/source/enumerator/TieringSourceEnumerator.java | Emits a skip-round split for fully caught-up tables when mark-done is enabled. |
| fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/tiering/committer/TieringCommitOperator.java | Runs mark-done maintenance and commits the resulting snapshot to Fluss when a round has no data. |
| fluss-common/src/main/java/org/apache/fluss/utils/PartitionUtils.java | Exposes partition time-format logic needed for auto-partition end-time derivation. |
| fluss-common/src/main/java/org/apache/fluss/lake/writer/PartitionMarkDoneEnabler.java | New optional capability interface for lake factories to signal mark-done support/enabling. |
| fluss-common/src/main/java/org/apache/fluss/lake/committer/PartitionMarkDoneMaintainer.java | New optional capability interface for lake committers to perform empty-round mark-done maintenance. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
beryllw
marked this pull request as draft
August 11, 2026 09:57
beryllw
force-pushed
the
feature/paimon-markdone
branch
from
August 11, 2026 15:47
5bddc70 to
30def66
Compare
beryllw
marked this pull request as ready for review
August 11, 2026 15:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…time)
Purpose
Linked issue: close #3314
Brief change log
Tests
API and Format
Documentation