HDFS-17869. QuorumJournalManager swallows root exception in catch blocks#8314
Open
balodesecurity wants to merge 3 commits intoapache:trunkfrom
Open
HDFS-17869. QuorumJournalManager swallows root exception in catch blocks#8314balodesecurity wants to merge 3 commits intoapache:trunkfrom
balodesecurity wants to merge 3 commits intoapache:trunkfrom
Conversation
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
QuorumJournalManager, nine methods catchInterruptedExceptionandTimeoutExceptionand rethrow asIOExceptionwithout chaining the original exception as the cause:Affected methods:
format,hasSomeData,doPreUpgrade,doUpgrade,doFinalize,canRollBack,doRollback,discardSegments,getJournalCTime.When these exceptions surface in logs or are caught upstream, the original stack trace (and the interrupted thread's state) is lost entirely, making the root cause of failures invisible during debugging.
Fix
Pass the caught exception as the second argument to
IOException(String, Throwable)in all 18 affected catch blocks, preserving the full exception chain.Testing
TestQuorumJournalManagerUnit#testFormatTimeoutExceptionIsCauseChained: configures a QJM with a 50 ms operations timeout, makes all loggers return futures that never resolve, callsformat(), and asserts that the thrownIOExceptionhas aTimeoutExceptionas its cause.