-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HDFS-11161. Incorporate Baidu BOS file system implementation. #8347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yangdong2398
wants to merge
5
commits into
apache:trunk
Choose a base branch
from
yangdong2398:HDFS-11161-hadoop-bos-clean
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+8,833
−0
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
afb04c0
HDFS-11161. Incorporate Baidu BOS file system implementation.
62aad1a
HDFS-11161. Address PR review feedback for hadoop-bos module.
a6aa28e
HDFS-11161. Fix CI: SpotBugs, checkstyle, and contract test failures.
15e2933
HDFS-11161. Add package-info.java for test packages to fix checkstyle…
bbe2216
HDFS-11161. Add directory-maven-plugin for standalone SpotBugs builds.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
62 changes: 62 additions & 0 deletions
62
hadoop-cloud-storage-project/hadoop-bos/dev-support/findbugs-exclude.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| <!-- | ||
| Licensed to the Apache Software Foundation (ASF) under one or more | ||
| contributor license agreements. See the NOTICE file distributed with | ||
| this work for additional information regarding copyright ownership. | ||
| The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| (the "License"); you may not use this file except in compliance with | ||
| the License. You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| --> | ||
| <FindBugsFilter> | ||
| <!-- BosInputStream stores mutable configuration and statistics | ||
| objects passed from the caller; defensive copies are | ||
| unnecessary for internal use. --> | ||
| <Match> | ||
| <Class name="org.apache.hadoop.fs.bos.BosInputStream"/> | ||
| <Or> | ||
| <Bug pattern="EI_EXPOSE_REP"/> | ||
| <Bug pattern="EI_EXPOSE_REP2"/> | ||
| </Or> | ||
| </Match> | ||
| <!-- BosOutputStream stores mutable store and configuration | ||
| objects passed from the caller. --> | ||
| <Match> | ||
| <Class name="org.apache.hadoop.fs.bos.BosOutputStream"/> | ||
| <Or> | ||
| <Bug pattern="EI_EXPOSE_REP"/> | ||
| <Bug pattern="EI_EXPOSE_REP2"/> | ||
| </Or> | ||
| </Match> | ||
| <!-- FileMetadata exposes ObjectMetadata and attribute Set | ||
| without defensive copies for performance. --> | ||
| <Match> | ||
| <Class name="org.apache.hadoop.fs.bos.FileMetadata"/> | ||
| <Or> | ||
| <Bug pattern="EI_EXPOSE_REP"/> | ||
| <Bug pattern="EI_EXPOSE_REP2"/> | ||
| </Or> | ||
| </Match> | ||
| <!-- PartialListing stores and returns arrays without | ||
| defensive copies for performance in listing operations. --> | ||
| <Match> | ||
| <Class name="org.apache.hadoop.fs.bos.PartialListing"/> | ||
| <Or> | ||
| <Bug pattern="EI_EXPOSE_REP"/> | ||
| <Bug pattern="EI_EXPOSE_REP2"/> | ||
| </Or> | ||
| </Match> | ||
| <!-- BosCRC32CCheckSum uses unsigned right shift on an int | ||
| value to extract individual bytes; this is intentional. --> | ||
| <Match> | ||
| <Class name="org.apache.hadoop.fs.bos.utils.BosCRC32CCheckSum"/> | ||
| <Method name="writeInt"/> | ||
| <Bug pattern="ICAST_QUESTIONABLE_UNSIGNED_RIGHT_SHIFT"/> | ||
| </Match> | ||
| </FindBugsFilter> | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which issues can be fixed? Additionally, it's better to suppress issues as precisely as possible rather than using broad suppressions.