HADOOP-19843. Regenerate tracked proto2 source code#8350
Open
pan3793 wants to merge 7 commits intoapache:trunkfrom
Open
HADOOP-19843. Regenerate tracked proto2 source code#8350pan3793 wants to merge 7 commits intoapache:trunkfrom
pan3793 wants to merge 7 commits intoapache:trunkfrom
Conversation
pan3793
commented
Mar 18, 2026
...common/src/main/proto2-generated/org/apache/hadoop/ipc/protobuf/ProtobufRpcEngineProtos.java
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
steveloughran
left a comment
steveloughran
left a comment
There was a problem hiding this comment.
I like how you've made it work for more platforms and got RAT to stop complaining.
Contributor
|
I confirmed that generating ProtobufRpcEngineProtos.java on x86 matches the file in this PR. Any ideas what the patch unit root failures are about? +1 pending a good CI run. |
Contributor
|
Created #8358. My best guess for the CI failure is hitting nproc ulimit in Yetus CI container. We need a better way to re-trigger CI. |
steveloughran
approved these changes
Mar 20, 2026
Contributor
steveloughran
left a comment
steveloughran
left a comment
There was a problem hiding this comment.
+1
That vm oom problem is known intermittent and obviously unrelated
There may be trailing spaces, but given this is autogenerated stuff, not our problem
| * | ||
| * <pre> | ||
| ** Name of the RPC method | ||
| ** Name of the RPC method |
Contributor
There was a problem hiding this comment.
this is where all the EOLs are coming from.
@pan3793 this is what came out of protoc? in which case we go with what was generated.
Member
Author
There was a problem hiding this comment.
@steveloughran, yes, I just copied the generated file and committed it to git directly, without touching the file content.
Member
Author
|
last commit fixed the grammar in README.txt, no code change. |
|
💔 -1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Regenerate tracked proto2 source code for non-x86_64 platforms.
The issue was originally identified by @steveloughran, see background at https://lists.apache.org/thread/4sn3bb2qo9vz2kqgblhx3wdc35fkc3bd
Additionally, rename the folder
arm-javatoproto2-generatedand change the profile activation condition from arm arch to non-x86_64 arch, because there are other platforms, e.g., rsicv64, that have a similar problem with arm, we should make it more generic.How was this patch tested?
Pass CI for x86_64 platform verification.
And manually tested on M1 MacBook with dev container
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?AI Tooling
No AI usage.