fix: add missing direct include of <vector> in file_writer.h#584
Open
shangxinli wants to merge 1 commit intoapache:mainfrom
Open
fix: add missing direct include of <vector> in file_writer.h#584shangxinli wants to merge 1 commit intoapache:mainfrom
shangxinli wants to merge 1 commit intoapache:mainfrom
Conversation
file_writer.h uses std::vector directly (split_offsets return type) but relies on a transitive include for it. Add the missing <vector> include to follow the include-what-you-use principle.
shangxinli
force-pushed
the
fix-missing-unordered-map-include
branch
from
2072294 to
d48e5c8
Compare
shangxinli
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
file_writer.husesstd::vector<int64_t>as the return type ofWriter::split_offsets()but does not directly include<vector>, relying on a transitive include<vector>include to follow the include-what-you-use principle