refactor(io)!: add context to IO.Open and IO.Remove - #2067
Draft
laskoviymishka wants to merge 1 commit into
Draft
laskoviymishka wants to merge 1 commit into
laskoviymishka wants to merge 1 commit into
Conversation
`io.IO.Open` and `Remove` now take `context.Context`, matching `BulkRemovableIO.DeleteFiles`. `blobfs.FileIO.Remove` forwards the caller context so deletes honor cancellation/deadlines. `table.WithDeleteFunc` now takes `func(context.Context, string) error`. Breaking change: all `IO` implementations/callers must pass a context, and custom delete callbacks must update their signature. Part of the v1.0 API cleanup in apache#2062.
laskoviymishka
force-pushed
the
refactor/io-context-open-remove
branch
from
September 28, 2026 15:49
8bb6cb9 to
456cab5
Compare
2 of 14 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
io.IO.OpenandRemovenow takecontext.Context, matchingBulkRemovableIO.DeleteFiles.blobfs.FileIO.Removeforwards the caller context so deletes honor cancellation/deadlines.table.WithDeleteFuncnow takesfunc(context.Context, string) error.Breaking change: all
IOimplementations/callers must pass a context, and custom delete callbacks must update their signature.Part of the v1.0 API cleanup in #2062.