fix(rest): Encode table names in UTF-8 in REST paths - #2074
Open
alessandro-nori wants to merge 1 commit into
Open
alessandro-nori wants to merge 1 commit into
alessandro-nori wants to merge 1 commit into
Conversation
alessandro-nori
force-pushed
the
anori/fix-plus-table-identifiers
branch
from
September 29, 2026 08:47
44b2783 to
3842e21
Compare
alessandro-nori
force-pushed
the
anori/fix-plus-table-identifiers
branch
2 times, most recently
from
September 29, 2026 08:53
fa65eab to
5a45135
Compare
alessandro-nori
force-pushed
the
anori/fix-plus-table-identifiers
branch
from
September 29, 2026 09:00
5a45135 to
cd112dc
Compare
alessandro-nori
force-pushed
the
anori/fix-plus-table-identifiers
branch
from
September 29, 2026 09:06
cd112dc to
c84a31a
Compare
alessandro-nori
commented
Sep 29, 2026
| } | ||
|
|
||
| func TestEncodeString(t *testing.T) { | ||
| assert.Equal(t, "+%25%26%2B%C2%A3%E2%82%AC", encodeString(" %&+£€")) |
Contributor
Author
There was a problem hiding this comment.
alessandro-nori
marked this pull request as ready for review
September 29, 2026 09:14
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Motivation
REST table path parameters must distinguish literal plus signs from spaces. Encoding table names before inserting them into request paths preserves the original identifier while leaving other path component behavior unchanged.
Testing
go test ./catalog/restgo test ./catalog/...