cli: add log level param #2868
Open
cli: add log level param #2868
+97
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geruh
reviewed
Dec 28, 2025
nssalian
reviewed
Dec 28, 2025
| ) -> None: | ||
| logging.basicConfig( | ||
| level=getattr(logging, log_level.upper()), | ||
| format="%(levelname)s:%(name)s:%(message)s", |
There was a problem hiding this comment.
Could you add a timestamp, line no to this?
format="%(asctime)s:%(levelname)s:%(name)s:%(lineno)d:%(message)s" something like this?
Or better yet structured logging - not sure if that requires a larger change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
After #2867, I realized that there's no way to set log level for the CLI.
This PR introduces 2 ways to set log levels,
--log-levelandPYICEBERG_LOG_LEVEL. Default log level isWARNINGAre these changes tested?
Yes
Are there any user-facing changes?
Yes