Use RustFS readiness healthcheck and drop redundant settings - #4017
Draft
kevinjqliu wants to merge 1 commit into
Draft
kevinjqliu wants to merge 1 commit into
kevinjqliu wants to merge 1 commit into
Conversation
Use /health/ready so bucket creation waits for storage/IAM readiness, enable stdout logging so `docker logs` shows output, and remove settings that are already defaults in rustfs/rustfs:1.0.0. Generated-by: GitHub Copilot Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Updates RustFS Docker Compose configurations to use readiness checks, stdout logging, and default settings.
Changes:
- Switches healthchecks to
/health/ready. - Enables RustFS stdout logging.
- Removes redundant default settings.
| File | Description |
|---|---|
dev/docker-compose.yml |
Updates standalone RustFS configuration. |
dev/docker-compose-integration.yml |
Updates integration RustFS configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
kevinjqliu
marked this pull request as draft
September 25, 2026 04:17
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Follow up to apache/iceberg#18246. Now that all the Iceberg repos are on RustFS 1.0.0, this lines up the object store config here with the others (iceberg, iceberg-rust, iceberg-go, iceberg-cpp).
/health/readyinstead of/health./healthis just a liveness check and can return 200 before storage and IAM are ready, so theaws-clibucket creation can race it.RUSTFS_OBS_LOG_STDOUT_ENABLED. The image logs to/logsby default, sodocker logsis empty, which makes CI failures hard to debug.RUSTFS_VOLUMES,RUSTFS_ADDRESS,RUSTFS_CONSOLE_ENABLE, andRUSTFS_CONSOLE_ADDRESS. These are already the 1.0.0 defaults.Are these changes tested?
Ran
docker compose configon both files, and startedrustfs/rustfs:1.0.0with the new config:/health/readyreturns 200 and logs show up indocker logs.Are there any user-facing changes?
No.
AI Disclosure: Assisted by GitHub Copilot.