Conversation
Signed-off-by: 1fanwang <1fannnw@gmail.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Critical runtime failure and an undeclared dependency must be fixed.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
What changed in this PR
Adds support for forwarding s3.ssl.ca-cert to PyArrow S3/OSS filesystems, with PyArrow version validation.
Changes:
- Defines the S3 CA certificate property.
- Passes the CA path to PyArrow.
- Adds propagation and compatibility tests.
Review blockers: the implementation references undefined pyarrow instead of pa, and uses an undeclared runtime packaging dependency.
| File | Description |
|---|---|
tests/io/test_pyarrow.py |
Tests CA propagation and version requirements. |
pyiceberg/io/pyarrow.py |
Adds TLS CA configuration and version checks. |
pyiceberg/io/__init__.py |
Defines the CA certificate property. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+462
to
+466
| if version.parse(pyarrow.__version__) < version.parse(min_pyarrow_version_supporting_tls_ca_file_path): | ||
| raise ImportError( | ||
| f"pyarrow version >= {min_pyarrow_version_supporting_tls_ca_file_path} required for " | ||
| f"S3FileSystem tls_ca_file_path support, but found version {pyarrow.__version__}." | ||
| ) |
Signed-off-by: 1fanwang <1fannnw@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #3866
Rationale for this change
The PyArrow FileIO path accepted s3.ssl.ca-cert in catalog properties, but it did not pass the value into PyArrow's S3 client. Users with private S3 endpoints or self signed certificates could still hit curlCode: 60 during PyArrow reads and writes.
This change maps the existing Iceberg property to PyArrow's TLS CA file argument for S3 and OSS filesystems. PyArrow added that argument in 21.0.0, so older PyArrow versions now fail fast only when the CA certificate property is set.
Are these changes tested?
Yes.
Raw logs
Before 545cb66:
After 545cb66:
Adjacent S3 property checks passed: 4 passed, 241 deselected in 1.54s.
Are there any user-facing changes?
Yes. s3.ssl.ca-cert now takes effect for PyArrow-backed S3 and OSS file operations when PyArrow is 21.0.0 or newer.
AI Disclosure
AI disclosure: GitHub Copilot CLI (Claude Opus 5.5) wrote this change and its tests, and an automated coordinator reviewed the diff and test output before submission.
Areas of uncertainty: none known.