feat!(storage): Integration Storage trait with FileIO#2116
Open
CTTY wants to merge 3 commits intoapache:mainfrom
Open
feat!(storage): Integration Storage trait with FileIO#2116CTTY wants to merge 3 commits intoapache:mainfrom
CTTY wants to merge 3 commits intoapache:mainfrom
Conversation
CTTY
commented
Feb 5, 2026
| use crate::runtime::runtime; | ||
|
|
||
| /// Parse the scheme from a URL and return the appropriate StorageFactory. | ||
| fn storage_factory_from_path(path: &str) -> PyResult<Arc<dyn StorageFactory>> { |
Collaborator
Author
There was a problem hiding this comment.
We probably need to add storage wrapper for user to better configure the storage backend they want to use. Right now it's hard wired to opendal for simplicity
CTTY
force-pushed
the
ctty/update-fileio
branch
from
082d2d2 to
7d692d8
Compare
CTTY
force-pushed
the
ctty/update-fileio
branch
from
d74a640 to
df9dcf0
Compare
Collaborator
Author
|
Hi @blackmwk, this PR is to wrap up the phase 1 work of Storage trait and is ready for review |
blackmwk
reviewed
Feb 27, 2026
|
|
||
| let file_io = FileIO::from_path(&config.warehouse)? | ||
| // Use provided factory or default to LocalFsStorageFactory | ||
| let factory = storage_factory.unwrap_or_else(|| Arc::new(LocalFsStorageFactory)); |
Contributor
There was a problem hiding this comment.
I think by default we should use OpenDalStroageFactory?
Collaborator
Author
There was a problem hiding this comment.
OpenDalStorageFactory will be moved to iceberg-storage-opendal in the next PR. Using OpenDalStorageFactory here will create a dependency on opendal crate which is not ideal
|
|
||
| let file_io = FileIO::from_path(&config.warehouse)? | ||
| // Use provided factory or default to LocalFsStorageFactory | ||
| let factory = storage_factory.unwrap_or_else(|| Arc::new(LocalFsStorageFactory)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
FileIOto holddyn Storageinstead ofOpenDalStorageFileIOBuilderaccordinglyExtensionsfromFileIOwith_storage_factoryinCatalogBuilderand update all implementations accordinglydyn StorageFactorytoIcebergTableProviderFactoryAre these changes tested?
Mostly rely on the existing tests, added some uts for FileIOBuilder