Skip to content

infra: improve python binding setup#2178

Merged
blackmwk merged 4 commits intoapache:mainfrom
kevinjqliu:kevinjqliu/improve-python-binding-setup
Feb 26, 2026
Merged

infra: improve python binding setup#2178
blackmwk merged 4 commits intoapache:mainfrom
kevinjqliu:kevinjqliu/improve-python-binding-setup

Conversation

@kevinjqliu
Copy link
Contributor

@kevinjqliu kevinjqliu commented Feb 25, 2026

Which issue does this PR close?

  • Closes #.

What changes are included in this PR?

While reviewing #1997, i noticed a couple of improvements we can make

  1. make install should install the local editable pyiceberg-core so that i can do make install && make test
  2. CI should fail on warnings
  3. test should not read local env files (we made a similar fix in pyiceberg fix: ignore local config during tests iceberg-python#3006). Otherwise, tests were reading ~/.pyiceberg.yaml and polluting the runs

Are these changes tested?

Yes.

For (2), see that it fails in CI before removing the use of deprecated register_table_provider

Copy link
Contributor

@blackmwk blackmwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kevinjqliu for this fix!

@blackmwk blackmwk merged commit 8de1826 into apache:main Feb 26, 2026
19 checks passed
@kevinjqliu kevinjqliu deleted the kevinjqliu/improve-python-binding-setup branch February 26, 2026 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants