ci: enable RustFS stdout logging in docker compose - #3279
Draft
kevinjqliu wants to merge 1 commit into
Draft
kevinjqliu wants to merge 1 commit into
kevinjqliu wants to merge 1 commit into
Conversation
Set RUSTFS_OBS_LOG_STDOUT_ENABLED=true on the object-store service so that docker logs shows RustFS output, aligning with the canonical RustFS 1.0.0 setup used across Apache Iceberg repos. Generated-by: GitHub Copilot Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review comments; the change is focused and low risk.
Review effort: Lite
Findings: None
What changed in this PR
Enables RustFS stdout logging in the shared Docker Compose fixture to improve CI failure diagnostics.
Changes:
- Adds
RUSTFS_OBS_LOG_STDOUT_ENABLED=trueto the RustFS service.
| File | Summary |
|---|---|
dev/docker-compose.yaml |
Enables RustFS stdout logging. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
kevinjqliu
marked this pull request as draft
September 25, 2026 04:17
comphead
approved these changes
Sep 25, 2026
comphead
left a comment
comphead
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @kevinjqliu this is good observation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Turn on
RUSTFS_OBS_LOG_STDOUT_ENABLEDfor theobject-storeservice, same as the other Iceberg repos (iceberg, iceberg-python, iceberg-go, iceberg-cpp). The image logs to/logsby default, sodocker logsis empty, which makes CI failures hard to debug.The rest of the RustFS setup here already matches the other repos.
Are these changes tested?
Ran
docker compose config, and startedrustfs/rustfs:1.0.0with this setting: logs show up indocker logs.AI Disclosure
Implemented with GitHub Copilot.