Repository navigation
chore: Remove generated DEPENDENCIES.rust.tsv files, and associated scripts and guides - #3338
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The release guide retains obsolete instructions to regenerate the deleted dependency lists.
Review effort: Balanced
Findings: 1
What changed in this PR
Removes generated dependency TSV artifacts and generation workflow while retaining license validation.
Changes:
- Deletes all generated dependency TSV files.
- Removes generation logic and updates release guidance/configuration.
| File | Description |
|---|---|
website/src/release.md |
Removes TSV generation step. |
Makefile |
Updates cargo-deny synchronization note. |
dev/release/README.md |
Documents license checking only. |
dev/release/dependencies.sh |
Removes TSV generation support. |
.licenserc.yaml |
Removes TSV exclusion. |
crates/test_utils/DEPENDENCIES.rust.tsv |
Deletes generated list. |
crates/storage/opendal/DEPENDENCIES.rust.tsv |
Deletes generated list. |
crates/integrations/cache-moka/DEPENDENCIES.rust.tsv |
Deletes generated list. |
crates/integration_tests/DEPENDENCIES.rust.tsv |
Deletes generated list. |
crates/iceberg/DEPENDENCIES.rust.tsv |
Deletes generated list. |
crates/examples/DEPENDENCIES.rust.tsv |
Deletes generated list. |
crates/catalog/sql/DEPENDENCIES.rust.tsv |
Deletes generated list. |
crates/catalog/s3tables/DEPENDENCIES.rust.tsv |
Deletes generated list. |
crates/catalog/rest/DEPENDENCIES.rust.tsv |
Deletes generated list. |
crates/catalog/loader/DEPENDENCIES.rust.tsv |
Deletes generated list. |
crates/catalog/hms/DEPENDENCIES.rust.tsv |
Deletes generated list. |
crates/catalog/glue/DEPENDENCIES.rust.tsv |
Deletes generated list. |
bindings/python/DEPENDENCIES.rust.tsv |
Deletes generated list. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dannycjones
marked this pull request as draft
October 4, 2026 17:35
…cripts and guides
dannycjones
force-pushed
the
remove-dependency-tsvs
branch
from
October 4, 2026 17:36
67b344d to
aa5fcbf
Compare
dannycjones
marked this pull request as ready for review
October 4, 2026 17:48
Contributor
Author
|
@kevinjqliu this is ready to review. CI failed but it looks transient. |
Contributor
Author
blackmwk
approved these changes
Oct 9, 2026
blackmwk
left a comment
blackmwk
left a comment
Contributor
There was a problem hiding this comment.
Thanks @dannycjones for this pr!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
This change removes all code and files related to the generated DEPENDENCIES.rust.tsv. This was discussed in #3233. Ultimately, the files are not serving maintainers nor consumers well and are not generated as part of any license obligation.
The pinning of cargo-deny version inside the script is removed as the output is no longer sensitive to it.
makeand CI still install a consistent version.Are these changes tested?
N/A
AI Disclosure
LLM helped strip out the code. Human review.