Repository navigation
test(reader): widen FLBA decimal page-index coverage and clarify docs - #3386
Merged
laskoviymishka merged 2 commits intoOct 11, 2026
Merged
Conversation
…d docs Address review feedback on apache#3328: - Reframe the width-guard doc and inline comment as defence-in-depth against a non-conforming writer - Hoist the duplicated min/max decode into a single closure. - Add page-index tests
JeonDaehong
reviewed
Oct 10, 2026
| /// signals a `column_index_truncate_length` truncation, and a truncated byte | ||
| /// prefix decodes to the wrong number under two's-complement. | ||
| /// Returns an error for a bound whose width differs from `type_length`. | ||
| /// Conforming writers never truncate a decimal column index (a truncated |
There was a problem hiding this comment.
I checked this claim against both writers: parquet 59.3.0 (the version in Cargo.lock) skips truncation for Decimal/Float16 FIXED_LEN_BYTE_ARRAY in can_truncate_value, while parquet-java 1.17.1's BinaryTruncator.getTruncator only truncates String/Enum/JSON/BSON and returns the no-op truncator for decimals. Therefore, the "non-conforming writer" framing holds for files written by both iceberg-rust and iceberg-java.
laskoviymishka
approved these changes
Oct 11, 2026
laskoviymishka
left a comment
laskoviymishka
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this one!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are included in this PR?
Address review feedback on #3328:
Are these changes tested?
Added tests