IGNITE-28331 Fix SQL search by _key for a composite pk in Calcite engine#12926
Open
tkalkirill wants to merge 31 commits intomasterfrom
Open
IGNITE-28331 Fix SQL search by _key for a composite pk in Calcite engine#12926tkalkirill wants to merge 31 commits intomasterfrom
tkalkirill wants to merge 31 commits intomasterfrom
Conversation
tkalkirill
changed the title
vldpyatkov
reviewed
Mar 26, 2026
...alcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/IndexScan.java
Outdated
Show resolved
Hide resolved
vldpyatkov
reviewed
Mar 26, 2026
...alcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/IndexScan.java
Outdated
Show resolved
Hide resolved
vldpyatkov
reviewed
Mar 26, 2026
...c/main/java/org/apache/ignite/internal/processors/query/calcite/schema/SchemaHolderImpl.java
Outdated
Show resolved
Hide resolved
zstan
reviewed
Mar 26, 2026
...alcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/IndexScan.java
Outdated
Show resolved
Hide resolved
vldpyatkov
reviewed
Mar 26, 2026
...alcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/IndexScan.java
Outdated
Show resolved
Hide resolved
vldpyatkov
approved these changes
Mar 27, 2026
Contributor
|
seems also some kind of jmh benchmarks are necessary here, wdyt? |
Contributor
Author
|
@zstan I don't think it's necessary; using an index instead of a full table scan is a more or less obvious performance boost. |
...a/org/apache/ignite/internal/processors/query/calcite/exec/IndexWrappedKeyFirstLastScan.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/ignite/internal/processors/query/calcite/exec/IndexWrappedKeyScan.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/ignite/internal/processors/query/calcite/schema/CacheIndexImpl.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/ignite/internal/processors/query/calcite/schema/SchemaHolderImpl.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/ignite/internal/processors/query/calcite/schema/SchemaHolderImpl.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/ignite/internal/processors/query/calcite/exec/IndexWrappedKeyScan.java
Outdated
Show resolved
Hide resolved
...lcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/RowHandler.java
Outdated
Show resolved
Hide resolved
...va/org/apache/ignite/internal/processors/query/calcite/integration/SelectByKeyFieldTest.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/ignite/internal/processors/query/calcite/schema/SchemaHolderImpl.java
Outdated
Show resolved
Hide resolved
...va/org/apache/ignite/internal/processors/query/calcite/integration/SelectByKeyFieldTest.java
Show resolved
Hide resolved
...ain/java/org/apache/ignite/internal/processors/query/calcite/exec/LogicalRelImplementor.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/ignite/internal/processors/query/calcite/schema/CacheIndexImpl.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/ignite/internal/processors/query/calcite/exec/IndexFirstLastScan.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/ignite/internal/processors/query/calcite/exec/IndexFirstLastScan.java
Outdated
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-28331