Skip to content

feat: add support for custom serviceAccount name for lake and ui deployments#368

Merged
klesh merged 1 commit intoapache:mainfrom
3khenrique:add-custom-sa-support
Apr 18, 2026
Merged

feat: add support for custom serviceAccount name for lake and ui deployments#368
klesh merged 1 commit intoapache:mainfrom
3khenrique:add-custom-sa-support

Conversation

@3khenrique
Copy link
Copy Markdown
Contributor

What changes were introduced?

  • Added optional serviceAccount.name parameter to lake and ui sections in values.yaml
  • Updated lake and ui deployment templates to conditionally set serviceAccountName when a value is provided

Why is this change needed?

Currently, the Helm chart offers no way to assign a custom ServiceAccount to the lake or ui pods. They always fall back to the namespace default. This is a common requirement in environments with fine-grained RBAC, Workload Identity (GCP) or other pod-level identity mechanisms.

Key features:

  • Backward compatible: fields default to empty. Existing installations are unaffected.
  • Non-invasive: serviceAccountName is only injected into the pod spec when a name is explicitly provided

Usage example:

lake:
  serviceAccount:
    name: "devlake-lake-sa"

ui:
  serviceAccount:
    name: "devlake-ui-sa"

Copy link
Copy Markdown
Contributor

@klesh klesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks for your contribution.

@klesh klesh merged commit 37978b2 into apache:main Apr 18, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants